Shine Getter Javascript

Adventurer
1

Hello Everybody,

My code seems to work at the beginning, the character moves to the first tree gold coins but then stops go… when it loops, it tells me that coin was null… I don’t really get it… if someone has an idea…

    var coins = this.findItems();
    var coinIndex = 0;
loop {

    while (coinIndex < 100) {
    // Wrap this into a loop that iterates over all coins.  
        var coin = coins[coinIndex];
        coinIndex = coinIndex + 1;
    // Gold coins are worth 3.
        if (coin.value == 3) {
          // Only pick up gold coins.
            var coinp = coin.pos;
            var x = coinp.x;
            var y = coinp.y;
            this.moveXY(x, y);
        }
    }
}
2

this.findItems() finds all items currently present. This includes 3 Goldcoins. Your loop iterates over all coins and finds these 3 gold-coins, collecting them.

The level spawns new Gold-Coins once the old ones are collected. But you never search for them again. You only count coinIndex to 100 and your program ends because there are not 100 Coins present.

The following code should solve your problems:

loop{
    var coins = this.findItems();      //Finds all coins
    var coinIndex = 0;                 //Reset coinIndex to 0
    
    //Increment coinIndex until 
    //coinIndex == the amount of coins (which will break the loop)
    while (coinIndex < coins.length){  
        var coin = coins[coinIndex];
        coinIndex = coinIndex + 1;
        
        //check if it is a gold-coin and collect it
    }
}
1 Like
3

You were right it was really helpful… I had a second question why the var coins and coinIndex have to be into the loop… I have never really understood the logic sometime it seems they are part of the loop and sometimes out of the loop… could you explain me the meaning behind… (that was one of the reason that also provoke my problem)

4

When do I put this.findItems() in the loop and when don’t I do this?
This depends whether you want to run the command multiple times or not. If you want the command to run multiple times, you put it in a loop. If you want to run it only once, you don’t put it in a loop. Simple as that.

Attention, Techie-Talk incoming!
I will talk about loops and what the computer does to them. This is not required to understand the answer. It may help you understanding what happens inside your computer though.

The code you write will be executed once for the whole level.

It will start at the top and run till the last instruction. If the computer finds a loop- or a while- command, it may jump to an earlier point of your code, exactly to the loop-command.

A loop can cause your program to run forever. Actually, this is what loop does. while is a bit nicer. If programmed right, it can stop running. loop {...} is the same as while(true) {...}

Back to topic:
Let’s say a levels ask us to collect all items. The items are already present, they do not spawn later. Your code would look like this:

var items = this.findItems();    //1
var index = 0;                   //2
                                 //3
while(index < coins.length){     //4
    //collect item               //5
    index = index +1;            //6
}                                //7
                                 //8

Lines 1 and 2 are outside of the loop. They will be executed exactly once. The program then executes line 4 once. If (and only if) the condition is true, the program goes to line 5. Let’s say we found an item. The program executes line 5 and 6. The program then goes to line 7. Line 7 is the end of the loop. Instead of executing line 8 next, the program goes to line 4. Let’s say this time that the condition becomes false. Now, the program goes to line 8. As line 8 is the last line, the program ends.

We now look at the execution order a bit summarized (Note: items.length = 1, that is we have 1 item):

/*
For clarity, I directly resolved variables. This is important for the if-statements
*/

Execute Line 1    -> var coins = this.findItems()
Execute Line 2    -> var index = 0
Execute Line 3    -> 
Execute Line 4    -> if 0 < 1 then GOTO LINE 5 else GOTO LINE 8
/*    -> GOTO Line 5                             */
Execute Line 5    -> //collect coin
Execute Line 6    -> index = 0 + 1
/*    -> index is now 1                          */
Execute Line 7    -> GOTO LINE 4
/*    -> Translated: GOTO start of while-loop    */
Execute Line 4    -> if 1 < 1 then GOTO LINE 5 else GOTO LINE 8
/*    -> GOTO Line 8                             */
Execute Line 8    -> 
>>> End of Program

As you can see, there is a lot of GOTO going on here. Sadly, reading a program made understandable for a computer makes it almost unreadable for a human.

1 Like
5

I am having trouble this is my code
var coins = this.findItems();
var coinIndex = 0;
loop{
coins = this.findItems(); //Finds all coins
coinIndex = 0; //Reset coinIndex to 0

//Increment coinIndex until 
//coinIndex == the amount of coins (which will break the loop)
while (coinIndex < coins.length){  
    var coin = coins[coinIndex];
    coinIndex = coinIndex + 1;
    
    //check if it is a gold-coin and collect it
}

}

6

Again, @DrTerror_Joseph PLEASE format your code! Look at the discourse FAQ!