[SOLVED] Define commandSoldier()

Level Help
1

can someone help me on how to define commandSoldier
(this is not for a specific level)
my code is

def commandSoldier(soldier):
    target = hero.findNearestEnemy()
    if (target):
        hero.command(soldier, "attack", target)

on line 4 it says command’s argument minion should have type unit, but got null

2

You have to define your soldier first. Then you could use it in a for-loop.
Lydia

3

like this? @Lydia_Song

def commandSoldier(soldier):
    soldier = hero.findByType("soldier")
    target = hero.findNearestEnemy()
    if (target):
        hero.command(soldier, "attack", target)
4

Not quite. Because you’re function uses a single target soldier, you’ll need to also use a for loop somewhere to loop through each of your soldiers.

for friend in friends:
    commandSoldier(fr...

This is an array, so you can’t use command with it - you can’t command a whole array in one statement (although that could be a cool feature if you just wanted all your troops to do the same thing…)
Danny

3 Likes
5

so like this?

def commandSoldier(soldier):
    soldier = hero.findNearest(soldiers)
    enemy = hero.findNearestEnemy()
    if enemy:
        hero.command(soldier, "attack", enemy)
6

What @Deadpool198 is saying is that when you define soldier as a parameter in your function, you do not need to define it again. In this case, it would be likely that you are using more then one type of friend; it would definitely save time like this, so well done on that. If so, then you shouldn’t define soldier and leave the function as it was at the start of this topic.
Next you need to define a for-loop that iterates through your friends. I’ll leave that to you to think about but in this case

for each friend in your friends:
    if your friend is a ...:
        command...(friend)

you would carry on with the required friends.
Elijah :lion:

2 Likes
7

now my code is


def commandSoldier(soldier):
    soldier = hero.findNearest(soldiers)
    enemy = hero.findNearestEnemy()
    for friend in friends:
        if soldier.type == "soldier":
            hero.command(soldier, "attack", enemy)

on line 2
it says soldiers is not defined

8

Try changing to friends = hero.findFriends And the soldier type to if friend.type == “soldier”

9

you havent defined “Soldiers” yet

10

And I would suggest to change condition a bit. Like
if enemy and enemy.health>0:

11 
def commandSoldier(soldier):
    #find friends
    for friend in friends:
        #if the friend type is soldier
             #find the enemy nearest to the friend or find the enemy nearest to your hero
                   #if there is an enemy
                       #command your soldier to attack the enemy

I hope this helps.
Lydia

12

which one do I listen to???

13

now my code is

def commandSoldier(soldier):
    friends = hero.findFriends()
    friend = hero.findNearest(friends)
    for friend in friends:
        if friend.type == "soldier":
            enemy = hero.findNearestEnemy()
            if enemy and enemy.health < 0: 
                hero.command(friend, "attack", enemy)
14

nvm i just messed up
it was

if enemy and enemy.health<0:

not

if enemy and enemy.health>0:

thank you Lydia_Song Alexbrand cheddarcheese Eric_Tang FalconX11_312 Deadpool198

1 Like
15

This topic was automatically closed 12 hours after the last reply. New replies are no longer allowed.