# Library tactician : help needed!

Hi guys!

I need help with my code for the level Library Tactician.
With the code below, there’s always one guy who dies. It looks like the archers are not trying to kill the ogre with the most health but always the nearest!
What can I do?

Thanks!

``````# Hushbaum has been ambushed by ogres!
# She is busy healing her soldiers, you should command them to fight!
# The ogres will send more troops if they think they can get to Hushbaum or your archers, so keep them inside the circle!

# Soldiers spread out in a circle and defend.
def commandSoldier(soldier, soldierIndex, numSoldiers):
angle = Math.PI * 2 * soldierIndex / numSoldiers
defendPos = {"x": 41, "y": 40}
defendPos.x += 10 * Math.cos(angle)
defendPos.y += 10 * Math.sin(angle)
hero.command(soldier, "defend", defendPos);

# Find the strongest target (most health)
# This function returns something! When you call the function, you will get some value back.
def findStrongestTarget():
mostHealth = 0
bestTarget = None
enemies = hero.findEnemies()
# Figure out which enemy has the most health, and set bestTarget to be that enemy.
for enemy in enemies:
if enemy.health > mostHealth:
mostHealth = enemy.health
bestTarget = enemy

# Only focus archers' fire if there is a big ogre.
if bestTarget and bestTarget.health > 15:
return bestTarget
else:
return None

# If the strongestTarget has more than 15 health, attack that target. Otherwise, attack the nearest target.
def commandArcher(archer):
nearest = archer.findNearestEnemy()
if archerTarget:
hero.command(archer, "attack", archerTarget)
elif nearest:
hero.command(archer, "attack", nearest)

archerTarget = None

while True:
# If archerTarget is dead or doesn't exist, find a new one.
if not archerTarget or archerTarget.health <= 0:
# Set archerTarget to be the target that is returned by findStrongestTarget()
archerTarget = findStrongestTarget()

friends = hero.findFriends()
soldiers = hero.findByType("soldier")
# Create a variable containing your archers.
archers = hero.findByType("archer")
for i in range(len(soldiers)):
soldier = soldiers[i]
commandSoldier(soldier, i, len(soldiers));

# use commandArcher() to command your archers
for j in range(len(archers)):
archer = archers[j]
commandArcher(archer, j, len(archers))``````
2 Likes

Anyone has an idea?

Thanks

1 Like

You need to indent the lines in which you command your archers.

Trying out your code resulted in a lot of lag; you can try to make some optimizations to your code.

1. You only need to command the soldiers to defend once. (So just take that out of the main loop.)
2. As no ally is supposed to die, you only need to find your soldiers and archers once (so also move the assignment out of the main loop). And if you use `findByType(type)`, you don’t have to use `findFriends()`.
3. When you call `commandArcher`, you only need to pass in an `archer`, nothing else. Also, you can simply use `for archer in archers: commandArcher(archer)`
1 Like

It worked!
Thanks so much!

for in range it’s i not j