Library Tactician - help

Level Help
1

Archers appear to not target the strongest enemy. Any help is appreciated.

var archerTarget = null;

// Soldiers spread out in a circle and defend.
function commandSoldier(soldier, soldierIndex, numSoldiers) {
    var angle = Math.PI * 2 * soldierIndex / numSoldiers;
    var defendPos = {x: 41, y: 40};
    defendPos.x += 10 * Math.cos(angle);
    defendPos.y += 10 * Math.sin(angle);
    hero.command(soldier, "defend", defendPos);
}
// Find the strongest target (most health)
// This function returns something! When you call the function, you will get some value back.
function findStrongestTarget() {
    var mostHealth = 0;
    var bestTarget = null;
    var enemies = hero.findEnemies();
    // Figure out which enemy has the most health, and set bestTarget to be that enemy.
    for(var i=0;i<enemies;i++){
        var enemie = enemies[i];
        if (enemie.health > mostHealth) {
            mostHealth = enemie.health;
            bestTarget = enemie;    
        }
    }
    // Only focus archers' fire if there is a big ogre.
    if (bestTarget && bestTarget.health > 15) {
        return bestTarget;
    } else {
        return null;
    }
}
// If the strongestTarget has more than 15 health, attack that target. Otherwise, attack the nearest target.
function commandArcher(archer) {
    var nearest = archer.findNearestEnemy();
    if(archerTarget) {
        hero.command(archer, "attack", archerTarget);
    } else if(nearest) {
        hero.command(archer, "attack", nearest);
    }
}

while(true) {
    // If archerTarget is defeated or doesn't exist, find a new one.
    if(!archerTarget || archerTarget.health <= 0) {
        // Set archerTarget to be the target that is returned by findStrongestTarget()
        archerTarget = findStrongestTarget();
    }
    var friends = hero.findFriends();
    var soldiers = hero.findByType("soldier");
    // Create a variable containing your archers.
    var archers = hero.findByType("archers");
    for(var i=0; i < soldiers.length; i++) {
        var soldier = soldiers[i];
        commandSoldier(soldier, i, soldiers.length);
    }
    for(var i=0;i<archers.length;i++){
        var archer = archers[i];
        commandArcher(archer);
        }
    // use commandArcher() to command your archers
}
2

I haven’t tested this, but I’m pretty sure this is the only error. It’s a typo. It should be “archer”, singular, not “archers”, plural.
When you use hero.findByType(), you always have to use the .type of the unit, which is always singular.
Danny

3

I think it might be in your function calling part

commandArcher(archer);

is different from the way you called the soldiers function

 commandSoldier(soldier, i, soldiers.length);

maybe I think it is in that part

4

I believe different parameters are required to execute those two functions.

5

It looks like the archer fire is now more concentrated, but still failing the level. Really not sure what’s going on lol

6

Please could you post your new code.
This level is a tricky one. It sometimes acts quite strangely.
I’ll give your code a test and see if I can fix it.
Danny

7

No @help The way you are calling the function is wrong. You should do this

commandArcher(archer, i, archer.length);
10

@Deadpool198 is right too you need to keep

var archers = hero.findByType("archer");

instead of

var archers = hero.findByType("archers");
11 
var archerTarget = null;

// Soldiers spread out in a circle and defend.
function commandSoldier(soldier, soldierIndex, numSoldiers) {
    var angle = Math.PI * 2 * soldierIndex / numSoldiers;
    var defendPos = {x: 41, y: 40};
    defendPos.x += 10 * Math.cos(angle);
    defendPos.y += 10 * Math.sin(angle);
    hero.command(soldier, "defend", defendPos);
}
// Find the strongest target (most health)
// This function returns something! When you call the function, you will get some value back.
function findStrongestTarget() {
    var mostHealth = 0;
    var bestTarget = null;
    var enemies = hero.findEnemies();
    // Figure out which enemy has the most health, and set bestTarget to be that enemy.
    for(var i=0;i<enemies;i++){
        var enemie = enemies[i];
        if (enemie.health > mostHealth) {
            mostHealth = enemie.health;
            bestTarget = enemie;    
        }
    }
    // Only focus archers' fire if there is a big ogre.
    if (bestTarget && bestTarget.health > 15) {
        return bestTarget;
    } else {
        return null;
    }
}
// If the strongestTarget has more than 15 health, attack that target. Otherwise, attack the nearest target.
function commandArcher(archer) {
    var nearest = archer.findNearestEnemy();
    if(archerTarget) {
        hero.command(archer, "attack", archerTarget);
    } else if(nearest) {
        hero.command(archer, "attack", nearest);
    }
}

while(true) {
    // If archerTarget is defeated or doesn't exist, find a new one.
    if(!archerTarget || archerTarget.health <= 0) {
        // Set archerTarget to be the target that is returned by findStrongestTarget()
        archerTarget = findStrongestTarget();
    }
    var friends = hero.findFriends();
    var soldiers = hero.findByType("soldier");
    // Create a variable containing your archers.
    var archers = hero.findByType("archer");
    for(var i=0; i < soldiers.length; i++) {
        var soldier = soldiers[i];
        commandSoldier(soldier, i, soldiers.length);
    }
    for(var i=0;i<archers.length;i++){
        var archer = archers[i];
        commandArcher(archer);
        }
    // use commandArcher() to command your archers
}
12

Yaay, this is very satisfying.
I found the error. There’s only one, and it’s on this line:

Remember that enemies is an array, not a number, and you can only compare numbers with < and >. How can you access the length of an array? (clue’s in the name).
If you change that, it will work :grin:.
Danny

13

Thats it! such a simple mistake lol. Much thanks for the assist.

1 Like
14

This topic was automatically closed 12 hours after the last reply. New replies are no longer allowed.