[SOLVED] Library Tactictian HELP! SOS

ww2_tanker · June 23, 2020, 7:45pm

Please need help my code is correct but an archer dies in the end.
Here is my code:

defcommandSoldier(soldier, soldierIndex, numSoldiers):
angle = Math.PI * 2 * soldierIndex / numSoldiers
defendPos = {“x”: 41, “y”: 40}
defendPos.x += 10 * Math.cos(angle)
defendPos.y += 10 * Math.sin(angle)
self.command(soldier, “defend”, defendPos);

def findStrongestTarget():
mostHealth = 0
enemies = self.findEnemies()
enemyIndex = 0
for enemy in hero.findEnemies():
if enemy.health > mostHealth:
bestTarget = enemy
mostHealth = enemy.health
bestTarget = enemy
if bestTarget and bestTarget.health > 15:
return bestTarget
else:
return None

def commandArcher(archer):
nearest = archer.findNearestEnemy()
if archerTarget:
hero.command(archer, “attack”, archerTarget)
elif nearest:
hero.command(archer, “attack”, nearest)

archerTarget = None

while True:

if self.gold > self.costOf("soldier"):
    self.summon("soldier")
if not archerTarget or archerTarget.health <= 0:
    archerTarget = findStrongestTarget()
    friends = self.findFriends()
    soldiers = self.findByType("soldier")
    archers = self.findByType("archers")
for i, soldier in enumerate(soldiers):
    commandSoldier(soldier, i, len(soldiers));
for i in range(len(archers)):
    archer = archers[i]
    commandArcher(archer)

dedreous · June 23, 2020, 7:50pm

Howdy and welcome to the forum!

I must first ask, why are you using ‘self’ in your code? This was replaced back around 2017 and is no longer used. Please provide your own, original code, so that we can help you.

Also, formatting of the code is critical. Please review this topic to learn how:
[Essentials] How To Post/Format Your Code Correctly

ww2_tanker · June 23, 2020, 7:53pm

Ooops sorry I will change it right away.

Thank You!

ww2_tanker · June 23, 2020, 7:54pm

Here is my code:

def commandSoldier(soldier, soldierIndex, numSoldiers):
angle = Math.PI * 2 * soldierIndex / numSoldiers
defendPos = {“x”: 41, “y”: 40}
defendPos.x += 10 * Math.cos(angle)
defendPos.y += 10 * Math.sin(angle)
hero.command(soldier, “defend”, defendPos);

def findStrongestTarget():
mostHealth = 0
enemies = hero.findEnemies()
enemyIndex = 0
for enemy in hero.findEnemies():
if enemy.health > mostHealth:
bestTarget = enemy
mostHealth = enemy.health
bestTarget = enemy
if bestTarget and bestTarget.health > 15:
return bestTarget
else:
return None

def commandArcher(archer):
nearest = archer.findNearestEnemy()
if archerTarget:
hero.command(archer, “attack”, archerTarget)
elif nearest:
hero.command(archer, “attack”, nearest)

archerTarget = None

while True:

if hero.gold > hero.costOf("soldier"):
    hero.summon("soldier")
if not archerTarget or archerTarget.health <= 0:
    archerTarget = findStrongestTarget()
    friends = hero.findFriends()
    soldiers = hero.findByType("soldier")
    archers = hero.findByType("archers")
for i, soldier in enumerate(soldiers):
    commandSoldier(soldier, i, len(soldiers));
for i in range(len(archers)):
    archer = archers[i]
    commandArcher(archer)

dedreous · June 23, 2020, 7:57pm

Ok, but you still need to format it properly. Please read this topic:
[Essentials] How To Post/Format Your Code Correctly

ww2_tanker · June 23, 2020, 7:58pm

Sorry I will do that right away

ww2_tanker · June 23, 2020, 7:59pm

Here is my code:

def commandSoldier(soldier, soldierIndex, numSoldiers):
angle = Math.PI * 2 * soldierIndex / numSoldiers
defendPos = {“x”: 41, “y”: 40}
defendPos.x += 10 * Math.cos(angle)
defendPos.y += 10 * Math.sin(angle)
hero.command(soldier, “defend”, defendPos);

def findStrongestTarget():
mostHealth = 0
enemies = hero.findEnemies()
enemyIndex = 0
for enemy in hero.findEnemies():
if enemy.health > mostHealth:
bestTarget = enemy
mostHealth = enemy.health
bestTarget = enemy
if bestTarget and bestTarget.health > 15:
return bestTarget
else:
return None

def commandArcher(archer):
nearest = archer.findNearestEnemy()
if archerTarget:
hero.command(archer, “attack”, archerTarget)
elif nearest:
hero.command(archer, “attack”, nearest)

archerTarget = None

while True:

if hero.gold > hero.costOf("soldier"):
    hero.summon("soldier")
if not archerTarget or archerTarget.health <= 0:
    archerTarget = findStrongestTarget()
    friends = hero.findFriends()
    soldiers = hero.findByType("soldier")
    archers = hero.findByType("archers")
for i, soldier in enumerate(soldiers):
    commandSoldier(soldier, i, len(soldiers));
for i in range(len(archers)):
    archer = archers[i]
    commandArcher(archer)

dedreous · June 23, 2020, 8:06pm

Indentations are critical in Python…for example, your first function definition should look like this:

def commandSoldier(soldier, soldierIndex, numSoldiers):
    angle = Math.PI * 2 * soldierIndex / numSoldiers
    defendPos = {“x”: 41, “y”: 40}
    defendPos.x += 10 * Math.cos(angle)
    defendPos.y += 10 * Math.sin(angle)
    hero.command(soldier, “defend”, defendPos);

When you copy and past from another web source, most likely github, you can lose this formatting. All of your code needs to be fixed…needs to be properly indented before we can proceed.

Otherwise, if you copy directly from you own code editor, your just need to use the three backticks (```) as explained in the topic I provided.

ww2_tanker · June 23, 2020, 8:08pm

I still don’t get it how do I fix the code?

dedreous · June 23, 2020, 8:19pm

Regardless, it is important to learn the techniques required to post code on this forum. However, if you pasted directly from your code editor, then formatting is certainly a concern.

Here’s a partial shot of what you would see when you first start the lesson:

Notice the blue bar running down the left side of the code editor? This indicates the first indentation. Towards the bottom of the pick, you also see a kind of white bar…this indicates another indent. These indents are 4 spaces, or ‘tabs’ (as offered by the code editor). Without these, we cannot determine if your problem is with an error in your code, or is related to indentation.

ww2_tanker · June 23, 2020, 8:29pm

def commandSoldier(soldier, soldierIndex, numSoldiers):
    angle = Math.PI * 2 * soldierIndex / numSoldiers
    defendPos = {"x": 41, "y": 40}
    defendPos.x += 10 * Math.cos(angle)
    defendPos.y += 10 * Math.sin(angle)
    hero.command(soldier, "defend", defendPos);

def findStrongestTarget():
    mostHealth = 0 
    enemies = hero.findEnemies() 
    enemyIndex = 0
for enemy in hero.findEnemies():
    if enemy.health > mostHealth:
        bestTarget = enemy
        mostHealth = enemy.health
        bestTarget = enemy
    if bestTarget and bestTarget.health > 15:
        return bestTarget
    else:
        return None



def commandArcher(archer):
    nearest = archer.findNearestEnemy()
    if archerTarget:
        hero.command(archer, "attack", archerTarget)
    elif nearest:
        hero.command(archer, "attack", nearest)
        
archerTarget = None

while True:
    
    if hero.gold > hero.costOf("soldier"):
        hero.summon("soldier")
    if not archerTarget or archerTarget.health <= 0:
        archerTarget = findStrongestTarget()
        friends = hero.findFriends()
        soldiers = hero.findByType("soldier")
        archers = hero.findByType("archers")
    for i, soldier in enumerate(soldiers):
        commandSoldier(soldier, i, len(soldiers));
    for i in range(len(archers)):
        archer = archers[i]
        commandArcher(archer)

ww2_tanker · June 23, 2020, 8:30pm

Please Reply!!!

dedreous · June 23, 2020, 8:30pm

Much better! Give me a moment to have a look now.

dedreous · June 23, 2020, 8:37pm

To start with, in your findStrongestTarget function, your ‘for enemy’ loop is outside of the definition…the entire block needs to be indented.

AnSeDra · June 24, 2020, 3:06am

Do you need any more help at this level?

ww2_tanker · June 24, 2020, 7:51pm

Yes I need help!!!

ww2_tanker · June 24, 2020, 7:51pm

Please reply!!!

AnSeDra · June 25, 2020, 4:13am

If you still need help, can you send us your code?

ww2_tanker · June 25, 2020, 7:49am

Here is my code:

def commandSoldier(soldier, soldierIndex, numSoldiers):
    angle = Math.PI * 2 * soldierIndex / numSoldiers
    defendPos = {"x": 41, "y": 40}
    defendPos.x += 10 * Math.cos(angle)
    defendPos.y += 10 * Math.sin(angle)
    hero.command(soldier, "defend", defendPos);

def findStrongestTarget():
    mostHealth = 0 
    enemies = hero.findEnemies() 
    enemyIndex = 0
for enemy in hero.findEnemies():
    if enemy.health > mostHealth:
        bestTarget = enemy
        mostHealth = enemy.health
        bestTarget = enemy
    if bestTarget and bestTarget.health > 15:
        return bestTarget
    else:
        return None



def commandArcher(archer):
    nearest = archer.findNearestEnemy()
    if archerTarget:
        hero.command(archer, "attack", archerTarget)
    elif nearest:
        hero.command(archer, "attack", nearest)
        
archerTarget = None

while True:
    
    if hero.gold > hero.costOf("soldier"):
        hero.summon("soldier")
    if not archerTarget or archerTarget.health <= 0:
        archerTarget = findStrongestTarget()
        friends = hero.findFriends()
        soldiers = hero.findByType("soldier")
        archers = hero.findByType("archers")
    for i, soldier in enumerate(soldiers):
        commandSoldier(soldier, i, len(soldiers));
    for i in range(len(archers)):
        archer = archers[i]
        commandArcher(archer)

AnSeDra · June 25, 2020, 8:10am

Try to put this inside the function (try to put 4 spaces before each of those lines).
Do you need any more assistance at this level?

Topic		Replies	Views
I need help with this library tactician	9	2267	March 10, 2016
Library tactics help pls! Level Help	6	261	September 9, 2021
Help, Library Tactician! [PYTHON] Level Help	9	1045	October 21, 2020
Library Tactician Dec '15/ Apr '21 Level Help	191	12650	April 23, 2021
[SOLVED] I need help with Library Tactician please Level Help	14	587	June 9, 2020

[SOLVED] Library Tactictian HELP! SOS

Related topics